Wes/oauth webview #126
Open
Wes/oauth webview #126
+3,605
−562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingLogan
reviewed
Jan 28, 2026
codingLogan
left a comment
codingLogan
left a comment
There was a problem hiding this comment.
If an implementation uses an API call for the Connect widget url that changes the scheme, to myapp for example, will the react-native-widget-sdk no longer receive and forward those widget messages to the host app?
1. API => to get widget url with scheme "myapp"
2. Host App
|---> registers a scheme of "myapp" for deep links or other features unknown to us
|---> SDK uses "mx" scheme for it's widget messages now
|---> Connect Widget we launch for the customer in the SDK will have the "myapp" scheme applied to any widget messages because of step 1.
Main concern to discover/validate. Does the SDK miss all widget messages if the scheme is not "mx"?
I like the idea of simplification as long as we can make sure we don't break implementations, or at least create docs explaining the break and how to fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.